Merge pull request #105 from dglol/issue-104

Widget's onclick handler for logger can run out of sync  (#105)

extension/data/widget/widget.js

@@ -7,8 +7,7 @@ var bindEvents = function () {
   let tooltipElements = [].slice.call(document.querySelectorAll("[data-tooltip]"));
 
   logger.onclick = function () {
-    logger.className = (logger.className === "enabled") ? "disabled" : "enabled";
-    self.port.emit("logging_changed");
+    self.port.emit("logger_click");
     self.port.emit("update_tooltip", this.dataset.tooltip);
   };
 
@@ -27,6 +26,12 @@ var hideSplashText = function () {
   hideSplashText = function () { return; }
 };
 
+self.port.on("logger_update", function (data) {
+  let logger = document.getElementById("logger");
+
+  logger.className = (data["active"]) ? "enabled" : "disabled";
+});
+
 self.port.on("update_garbage_collector", function (data) {
   hideSplashText();
 

extension/lib/main.js

@@ -92,23 +92,25 @@ exports.main = function (options, callbacks) {
   });
 
   // If logger is clicked, then the state must be changed
-  widget.port.on("logging_changed", function () {
+  widget.port.on("logger_click", function () {
     if (logger.active) {
       logger.stop();
     } else {
       logger.start();
     }
+
+    widget.port.emit("logger_update", { "active": logger.active });
   });
 
   widget.port.on("update_tooltip", function (data) {
-    if (data === 'logger' && logger.active) {
-      data = 'logger_enabled';
+    if (data === "logger" && logger.active) {
+      data = "logger_enabled";
     }
-    else if (data === 'logger') {
-      data = 'logger_disabled';
+    else if (data === "logger") {
+      data = "logger_disabled";
     }
 
-    widget.tooltip = config.extensions.wiget_tooltips[data];
+    widget.tooltip = config.extension.widget_tooltips[data];
   });
 };