Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove code for Firefox versions <13 because we don't support those anymore (#150) #150

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

whimboo commented Aug 10, 2012

No description provided.

Member

davehunt commented Aug 13, 2012

Are we not supporting ESR?

Contributor

whimboo commented Aug 13, 2012

Support for Firefox 10 ESR was there until SDK 1.6 or so. Following releases of the SDK only support the last Firefox release. So we can't support ESR anymore. But I wouldn't care about.

@davehunt davehunt and 1 other commented on an outdated diff Aug 15, 2012

extension/lib/garbage-collector.js
@@ -92,53 +70,21 @@ const reporter = EventEmitter.compose({
let type = aTopic;
if (config.application.branch >= 14) {
@davehunt

davehunt Aug 15, 2012

Member

Do we still need this if statement?

@whimboo

whimboo Aug 15, 2012

Contributor

Somehow this came back. Strange. I have updated the pull request. So please re-check.

@davehunt davehunt commented on the diff Aug 15, 2012

extension/lib/garbage-collector.js
- function getValueFor(aKey, aRegex) {
- var regexp = new RegExp(aKey + ":" + aRegex, "i");
- var matches = regexp.exec(aMessage);
-
- return matches ? matches[1] : undefined;
- }
-
- let data = {
- timestamp: Date.now()
- };
-
- this._collector_data[aType].forEach(function (aEntry) {
- data[aEntry.label] = getValueFor(aEntry.label, aEntry.regex)
- });
-
- return data;
}
})();
@davehunt

davehunt Aug 15, 2012

Member

It's not part of this pull, but this gives me a syntax error.

@davehunt

davehunt Aug 15, 2012

Member

Ah, it looks like it's due to the if statement above not being closed. I think we can safely remove the if statement.

Member

davehunt commented Aug 15, 2012

Looks good.

Contributor

whimboo commented Aug 15, 2012

@whimboo whimboo closed this Aug 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment