This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Change to_namespaced_keyword(s) to return a Result #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce error handling throughout db code. Fixes mozilla#331. r=nalexander
ncalexan
approved these changes
Feb 17, 2017
| @@ -11,7 +11,7 @@ | |||
| #![allow(dead_code)] | |||
|
|
|||
| use entids; | |||
| use errors::*; | |||
| use errors::{ErrorKind, Result}; | |||
There was a problem hiding this comment.
Worth noting that error-chain explicitly suggests use * here; but I'd rather we're happy, so keep it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to_namespaced_keyword(s) to return a Result rather than Option to reduce error handling throughout db code. Fixes #331. I think this is a good approach for reducing the to-be-implemented custom ErrorKind throughout code. You mentioned combining it into
schema.require_entid, but that's a different usage (it checks the ident_map).