Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a networking off-main-thread outcome #251

Closed
wants to merge 1 commit into from

Conversation

acreskeyMoz
Copy link
Contributor

This outcome examines omt-specific networking performance probes

This outcome examines omt-specific performance probes
@acreskeyMoz
Copy link
Contributor Author

This is my first time making use of glean timing_distributions.
I'm not sure if this is valid

select_expression = '{{agg_histogram_mean("metrics.timing_distribution.http_content_onstart_delay")}}'

@mikewilli
Copy link
Collaborator

It looks like you're missing the metrics data_source definition, which is why the validate-jetstream CI check is failing. I also tagged @danielkberry to help with reviewing the metric definitions.

@acreskeyMoz
Copy link
Contributor Author

Thanks.

I'm looking into some other glam probes and I'm pretty sure that my data extraction isn't correct.
So I'm expecting to need to also update the select_expression.

@mikewilli
Copy link
Collaborator

Are we still interested in updating and merging this outcome or can this PR be closed?

@acreskeyMoz
Copy link
Contributor Author

Oh, no longer needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants