This repository has been archived by the owner on May 14, 2020. It is now read-only.
Make btns buttons, inherit font family #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize was resetting font family of buttons to a general sans-serif. This still has theoretical problems of inheriting fonts for specific sections, but I don’t know that it’s going to be a realistic issue for us. Also makes the index page use `<button>` instead of the fictional `<btn>`
|
Can you also fix this so we retain our spacing between buttons in the demo? (Or switch to https://github.com/mozilla/mofo-bootstrap/blob/master/src/scss/demo.scss#L79 |
|
Also a couple other buttons seem to have lost their styles based on looking at the demo page. |
|
I updated that style and removed the buttons that were having issues from the demo page, because they weren't actually buttons that are built into bootstrap. |
|
Can you also remove that CSS targeting |
|
I changed it to |
|
Oh, NM |
gvn
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize was resetting font family of buttons to a general sans-serif. This still has theoretical problems of inheriting fonts for specific sections, but I don’t know that it’s going to be a realistic issue for us. The other option was to set the font-family of those elements to the font variable string we use, but I don't feel like it really makes a difference, as that can lead to cascade override issues later on.
Also makes the index page use
<button>instead of the fictional<btn>Closes #102