Skip to content
This repository has been archived by the owner on Jun 11, 2021. It is now read-only.

Trailing semicolon in provided SQL causes parsing error #49

Closed
pydolan opened this issue Jan 9, 2019 · 3 comments
Closed

Trailing semicolon in provided SQL causes parsing error #49

pydolan opened this issue Jan 9, 2019 · 3 comments

Comments

@pydolan
Copy link
Contributor

pydolan commented Jan 9, 2019

While it's easy enough to parse out a trailing semicolon, it might be good to ignore it if it's the last character in the provided SQL statement. Thoughts?
@klahnakoski
Copy link
Contributor

that sounds like a nice feature. I have also had SQL with trailing semicolons

Sonalisinghal added a commit to Sonalisinghal/moz-sql-parser that referenced this issue Feb 26, 2019
@Sonalisinghal
Pre-processes the Query, to remove trailing semicolon
817747f 
Fixes Issue mozilla#49
@Sonalisinghal Sonalisinghal mentioned this issue Feb 26, 2019
Merged
Sonalisinghal added a commit to Sonalisinghal/moz-sql-parser that referenced this issue Feb 28, 2019
@Sonalisinghal
Pre-processes the Query, to remove trailing semicolon
25ed1f5 
Fixes Issue mozilla#49
Sonalisinghal added a commit to Sonalisinghal/moz-sql-parser that referenced this issue Feb 28, 2019
@Sonalisinghal
Pre-processes the Query, to remove trailing semicolon
e64a462 
Fixes Issue mozilla#49
@nishikeshKardak
Copy link
Contributor

Is this issue still open? If yes, then can I work on it??

@klahnakoski
Copy link
Contributor

@nishikeshKardak This has been solved. Sorry I did not close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pydolan @klahnakoski @nishikeshKardak