This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
WIP: Enabled select_one_column test, already passes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klahnakoski I removed this line, and ran the tests. They still passed. |
updating my fork
…e when test The test_ugly_case_statement test is the only test in this file that has multiple when statements.
|
I assume you are still working on this. I will put "WIP" (Work In Progress) in the title to indicate it's not ready for merge. |
klahnakoski
changed the title
|
The test passed when I tried it, so it looked like the issue was resolved
there. Is there something else to consider?
On Fri, Jan 25, 2019 at 9:10 AM Kyle Lahnakoski ***@***.***> wrote:
I assume you are still working on this. I will put "WIP" (Work In
Progress) in the title to indicate it's not ready for merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApgUdj57qqzmy7hRkuLtd7OwJ8BEm-X9ks5vGxA6gaJpZM4aP6Uk>
.
--
Sam Smouha
samsmouha.com
|
|
There is still more to do, Either un-remove the |
|
Feel free to reopen this request if you want to continue working on it. |
|
Ok I have been looking at it, and will try to fix it this weekend.
On Fri, Feb 1, 2019 at 4:09 PM Kyle Lahnakoski ***@***.***> wrote:
Feel free to reopen this request if you want to continue working on it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ApgUdhcLbDHNm2GhTs2y2UK5DBxo-FFSks5vJK0RgaJpZM4aP6Uk>
.
--
Sam Smouha
samsmouha.com
|
|
Can you please re-open the request? I will look for a fix for the test_ugly_case_statement. Thanks. |
|
I assume work will not continue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.