Handle serials with a single missing leading zero. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python doesn't like integer values with leading zeroes, and I can't seem to make pyasn.1 provide the serial number in a format where I can obtain the raw DER-encoding. This works around the problem by testing the top bit after big-endian-ing the value, and if it's set, retry the filter checks with a prepended leading zero. Fixes #15
jcjones
force-pushed
the
15-fix-leading-zero
branch
from
97a1b0c
to
a864e89
Compare
mozkeeler
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python doesn't like integer values with leading zeroes, and I can't seem to
make pyasn.1 provide the serial number in a format where I can obtain the raw
DER-encoding.
This works around the problem by testing the top bit after big-endian-ing the
value, and if it's set, retry the filter checks with a prepended leading zero.
Fixes #15