Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting dynamic downsampling for enrollments query #187

Closed
mikewilli opened this issue Aug 29, 2023 · 2 comments
Closed

Supporting dynamic downsampling for enrollments query #187

mikewilli opened this issue Aug 29, 2023 · 2 comments

Comments

@mikewilli
Copy link
Contributor

Downsampling is an useful tool for enrollments queries on large experiments, but the easiest way to do this right now involves overriding the entire enrollments query to add a WHERE sample_id <= {value} clause without changing the rest of the template.

We should look into adding another parameter to the _build_enrollments_query_normandy function so that we can more easily specify a sample rate for enrollment queries. This should allow us to add support in metric-hub and metric-config-parser for a sample_rate (or similar) parameter that could get injected into the query from jetstream.

@danielkberry
Copy link
Contributor

Ideally, this would work for mobile experiments as well, though they definitely suffer from this issue less

@mikewilli
Copy link
Contributor Author

Yea true, might as well add it as an option to all of the enrollments queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants