Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - download Firefox Developer Edition based on version #504

Closed
silviuFlorin opened this issue Oct 16, 2018 · 3 comments
Closed

Enhancement - download Firefox Developer Edition based on version #504

silviuFlorin opened this issue Oct 16, 2018 · 3 comments
Labels
mentored python
Milestone
1.25

Comments

@silviuFlorin
Copy link

Currently there is no way to generate an URL for Firefox Developer Edition based on version. This feature could be very helpful in our project.

Example of URL: http://archive.mozilla.org/pub/devedition/candidates/54.0b11-candidates/

Usage suggestion:

from mozdownload import FactoryScraper
scraper = FactoryScraper('devedition', version='41.0b9-candidates')
@whimboo
Copy link
Contributor

whimboo commented Oct 17, 2018

This would just be a new application type, which needs to be added. Would you mind providing a patch?

Maybe it would be enough to add it here:
https://github.com/mozilla/mozdownload/blob/master/mozdownload/scraper.py#L29

@adamschmalhofer adamschmalhofer mentioned this issue Oct 17, 2018
Merged
@whimboo whimboo added this to the 1.25 milestone Oct 18, 2018
@whimboo
Copy link
Contributor

whimboo commented Oct 18, 2018

This feature request will be part of the next release of mozdownload.

whimboo pushed a commit that referenced this issue Oct 22, 2018
@whimboo
Added Support for Firefox Developer Edition (#504)
9ec6fc5
@whimboo
Copy link
Contributor

whimboo commented Oct 22, 2018

This got added by PR #505. We may release a new version of mozdownload soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mentored python
Projects
None yet
Milestone
1.25
Development

No branches or pull requests
2 participants
@whimboo @silviuFlorin