Added unittests for the TinderboxScraper (#161) #170
Conversation
| ] | ||
|
|
||
| thunderbird_tests = [ | ||
| # -a thunderbird -p linux --branch=comm-central |
There was a problem hiding this comment.
So we don't have comm-central as default branch for Thunderbird? Looks like we have to define that for each application then.
There was a problem hiding this comment.
tbh. I have been thinking about getting rid of the default mozilla-central branch and write a small method that checks if branch = None and then chooses a fitting default for each application.
This would make sense as mozilla-central is also not a good default for b2g either.
There was a problem hiding this comment.
Exactly. Can you get a new issue filed for please? Thanks.
|
The PR is outdated and needs an update. |
|
It looks like this pull needs to be updated again. Could you do so, and ping us once more when it's ready. :) |
|
|
||
| Maecenas aliquet velit vel turpis. Mauris neque metus, malesuada nec, ultricies sit amet, porttitor mattis, enim. In massa libero, interdum nec, interdum vel, blandit sed, nulla. In ullamcorper, est eget tempor cursus, neque mi consectetuer mi, a ultricies massa est sed nisl. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos hymenaeos. Proin nulla arcu, nonummy luctus, dictum eget, fermentum et, lorem. Nunc porta convallis pede. | ||
|
|
||
| Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Nam cursus. Morbi ut mi. Nullam enim leo, egestas id, condimentum at, laoreet mattis, massa. Sed eleifend nonummy diam. Praesent mauris ante, elementum et, bibendum at, posuere sit amet, nibh. Duis tincidunt lectus quis dui viverra vestibulum. Suspendisse vulputate aliquam dui. Nulla elementum dui ut augue. Aliquam vehicula mi at mauris. Maecenas placerat, nisl at consequat rhoncus, sem nunc gravida justo, quis eleifend arcu velit quis lacus. Morbi magna magna, tincidunt a, mattis non, imperdiet vitae, tellus. Sed odio est, auctor ac, sollicitudin in, consequat vitae, orci. Fusce id felis. Vivamus sollicitudin metus eget eros. |
There was a problem hiding this comment.
Why such a big file here? I thought we wanted to use the same content across files?
| mozdownload -a firefox -t tinderbox -p mac64 --branch=mozilla-central | ||
| mozdownload -a firefox -t tinderbox -p win32 --branch=mozilla-central | ||
| mozdownload -a firefox -t tinderbox -p win64 --branch=mozilla-central | ||
| mozdownload -a firefox -t tinderbox -p linux --branch=mozilla-central --extension=txt |
There was a problem hiding this comment.
You don't want to remove that given it's not automated yet.
…t to tinderbox - commented out for the moment
|
Ok, now we're there, I hope :) |
|
This looks good to me. |
| # 'target': 'mozilla-central-firefox-25.0a1.en-US.win32.installer-stub.exe', | ||
| # 'target_url': 'firefox/tinderbox-builds/mozilla-central-win32/' | ||
| # '1374583608/firefox-25.0a1.en-US.win32.installer-stub.exe'}, | ||
| # -a firefox -p win64 --branch=mozilla-central |
There was a problem hiding this comment.
Please move it back to the manual test list. We can add the automated test with the given PR.
|
Ok, done. Sorry for the delay |
|
This looks great. Pushed as 6f9cf9e |
This PR addresses issue #161
I created three builds per platform and where important, the files are different in size, so that an md5 sum would give different results.
I added in both firefox and thunderbird tinderbox builds a timestamp_conversion.txt file for everyone's convenience in case more test cases need to be created.
I apologise for the sheer amount of files with 'Lorem ipsum...' content ;)