Use wptserve for unit tests (#368) #369
Conversation
| @@ -89,5 +89,5 @@ def handle_data(self, data): | |||
| if not self.active_url: | |||
| return | |||
|
|
|||
| if self.active_url == data: | |||
| if data in self.active_url: | |||
There was a problem hiding this comment.
We need this change because the actual data can contain a final slash or not, while active_url always has it.
There was a problem hiding this comment.
Wouldn't it be safer to strip the final slash and then compare? data in self.active_url is a very generous condition.
There was a problem hiding this comment.
Let me check if that would work.
|
One question, otherwise looks good. |
|
@mjzffr I pushed another commit with some clean-up + a new test for names with spaces. Wanted to be sure that wptserve handles that correctly. Let me know if you like that now. Regarding the mozlog changes I can redo the commits after I got a r+. Sadly I missed those changes with my recent landing for issue #360. I could re-label it appropriately. |
|
@whimboo r+ |
|
I separated the commits for the wptserve and logging changes. Travis is running now. If results are passing I will get it landed. |
This PR will fix issue #368. @mjzffr can you please review it? Thanks