Fix platform filter value for querying Treeherder jobs (#388) #389
Conversation
| except: | ||
| value = values[0] | ||
|
|
||
| if api_endpoint == 'jobs': |
There was a problem hiding this comment.
Seems like if api_endpoint is not in ('jobs', 'job-log-url') then you can skip this options,values loop entirely.
There was a problem hiding this comment.
jog-log-url has a different data set as jobs. For jobs the list to filter is under results while for the other it's at the root level.
There was a problem hiding this comment.
I see that but my original comment is about something else: is if the endpoint is neither job-log-url nor jobs then you don't need to loop through options,values at all.
There was a problem hiding this comment.
Oh, now I see. I will check this after dinner.
|
@whimboo A few things look suspicious to me. Perhaps you can explain them away... :) |
|
@mjzffr I pushed an update. Please let me know what you think about the loops, and if that is ok for now. |
|
@mjzffr the latest commit should make you satisfied. :) |
|
@whimboo r+wc, which I leave completely to your discretion. |
This PR will fix issue #388 and also adds a couple more tests to check that the call chain for Treeherder API endpoints works correctly.