Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-select available port for localhost (#179) #678

Merged
merged 2 commits into from
May 8, 2024

Conversation

piri-p
Copy link
Contributor

@piri-p piri-p commented May 7, 2024

Fix #179 - Auto-select available port for localhost @whimboo
Not sure how to write test cases for this. From local debugging, it indeed auto-selects available port

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is testing code I don't think that we need a specific test case for that change. I've tried locally as well and it works like a charm as you already mentioned.

Thank you for the fix!

@whimboo whimboo merged commit df5afdb into mozilla:master May 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run local http server for tests on port 8080
2 participants