Merge pull request #68 from johngian/fix-delegate

Fix return value on delegation failure.

mozilla_django_oidc/contrib/auth0/utils.py

@@ -14,5 +14,7 @@ def refresh_id_token(id_token):
     }
 
     response = requests.post(delegation_url, data=data)
-    response.raise_for_status()
-    return response.json().get('id_token')
+
+    if response.status_code == requests.codes.ok:
+        return response.json().get('id_token')
+    return None

tests/auth0_tests/test_utils.py

@@ -15,6 +15,7 @@ class Auth0UtilsTestCase(TestCase):
     def test_successful_refresh_token(self, mock_post):
         """Test a successful attempt for a refresh id_token."""
         mock_response = Mock()
+        mock_response.status_code = 200
         mock_response.json.return_value = {
             'id_token': 'foobar'
         }
@@ -27,8 +28,8 @@ def test_successful_refresh_token(self, mock_post):
     def test_unsuccessful_attempt(self, mock_post):
         """Test an attempt to get a refresh token that raises an error."""
         mock_response = Mock()
+        mock_response.status_code = 401
         http_error = requests.exceptions.HTTPError()
         mock_response.raise_for_status.side_effect = http_error
         mock_post.return_value = mock_response
-        with self.assertRaises(Exception):
-            self.assertEqual(refresh_id_token('token'), None)
+        self.assertEqual(refresh_id_token('token'), None)