Merge pull request #35 from akatsoulas/better-url-naming

Simplify naming schema for urls.
mozilla · Oct 31, 2016 · b7c72ed · b7c72ed
2 parents 75341f4 + 52e5d80
commit b7c72ed
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/mozilla_django_oidc/urls.py b/mozilla_django_oidc/urls.py
@@ -3,8 +3,8 @@
 from mozilla_django_oidc import views
 
 urlpatterns = [
-    url(r'^oidc/authentication_callback/$', views.OIDCAuthenticationCallbackView.as_view(),
+    url(r'^callback/$', views.OIDCAuthenticationCallbackView.as_view(),
         name='oidc_authentication_callback'),
-    url(r'^oidc/authentication_init/$', views.OIDCAuthenticationRequestView.as_view(),
+    url(r'^authenticate/$', views.OIDCAuthenticationRequestView.as_view(),
         name='oidc_authentication_init'),
 ]
diff --git a/tests/test_auth.py b/tests/test_auth.py
@@ -77,7 +77,7 @@ def test_successful_authentication_existing_user(self, token_mock, request_mock)
             'client_secret': 'example_secret',
             'grant_type': 'authorization_code',
             'code': 'foo',
-            'redirect_uri': 'http://site-url.com/oidc/authentication_callback/'
+            'redirect_uri': 'http://site-url.com/callback/'
         }
         self.assertEqual(self.backend.authenticate(code='foo', state='bar'), user)
         token_mock.assert_called_once_with('id_token')
@@ -112,7 +112,7 @@ def test_successful_authentication_new_user(self, token_mock, request_mock):
             'client_secret': 'example_secret',
             'grant_type': 'authorization_code',
             'code': 'foo',
-            'redirect_uri': 'http://site-url.com/oidc/authentication_callback/',
+            'redirect_uri': 'http://site-url.com/callback/',
         }
         self.assertEqual(User.objects.all().count(), 0)
         self.backend.authenticate(code='foo', state='bar')

diff --git a/tests/test_views.py b/tests/test_views.py
@@ -128,7 +128,7 @@ def test_get(self, mock_random_string):
             'response_type': ['code'],
             'scope': ['openid'],
             'client_id': ['example_id'],
-            'redirect_uri': ['http://site-url.com/oidc/authentication_callback/'],
+            'redirect_uri': ['http://site-url.com/callback/'],
             'state': ['examplestring']
         }
         self.assertDictEqual(parse_qs(o.query), expected_query)