This repository has been archived by the owner on Nov 22, 2017. It is now read-only.
Bug 1274507 - mozci believes certain pgo builders are invalid #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently made some changes to get_buildername_metadata() to
consider 'pgo' buildes. Unfortunately, I believe somewhat is producing
certain pgo builders to be considered invalid.
This change attempts to make get_buildername_metadata() easier to
understand. It also makes some tests follow py.test syntax plus disable
the test for building graphs. To be enabled in a follow up.
An easy test was to run this command:
```python
import logging
from mozci.mozci import valid_builder
from mozci.utils.log_util import setup_logging
setup_logging(logging.DEBUG)
valid_builder('Windows XP 32-bit mozilla-inbound pgo test mochitest-browser-chrome-1')
```
[1]
mozilla@593c629#diff-080760856cfeb3690166d07dd9636fdfL266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently made some changes to get_buildername_metadata() to
consider 'pgo' buildes. Unfortunately, I believe somewhat is producing
certain pgo builders to be considered invalid.
This change attempts to make get_buildername_metadata() easier to
understand. It also makes some tests follow py.test syntax plus disable
the test for building graphs. To be enabled in a follow up.
An easy test was to run this command:
[1]
593c629#diff-080760856cfeb3690166d07dd9636fdfL266
This change is