Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(format): check for Fields existence before setting stack #12

Merged
merged 1 commit into from
May 12, 2016

Conversation

seanmonstar
Copy link
Contributor

By always assigning it, it cannot be undefined.

Closes #11

r? @jrgm

@jrgm
Copy link
Contributor

jrgm commented May 12, 2016

LGTM. Thanks.

@seanmonstar seanmonstar changed the title fix(format): always assign rec.Fields as an object fix(format): check for Fields existence before setting stack May 12, 2016
@seanmonstar seanmonstar merged commit ccc8ab8 into master May 12, 2016
@seanmonstar seanmonstar deleted the fields-undefined branch May 12, 2016 20:58
@rfk
Copy link
Contributor

rfk commented May 12, 2016

Should we cut a new release including this, and update all the things to use it?

@seanmonstar
Copy link
Contributor Author

I'm publishing 2.0.4

@rfk
Copy link
Contributor

rfk commented May 12, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants