Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

[Bug 871628] Add '--show-errors' and '--show-all' options to the automation scrips to provide improved logging/debugging #66

Closed
wants to merge 1 commit into from

Conversation

Mistborn
Copy link

Not sure what comment to leave here.

@whimboo
Copy link
Contributor

whimboo commented Sep 11, 2013

Thanks Vlad for the PR! What I still miss here is the code which fakes mozmill's self.option.test.

@whimboo
Copy link
Contributor

whimboo commented Sep 11, 2013

Hm. But I wonder given that we have to release another Mozmill 1.5 release if we want to get this fixed there. I think that would be a good idea, given that you already know where the failure is. So I filed bug 914980.

FYI this pull cannot be merged. Please check that you have merged the latest upstream changes on the hotfix-1.5 branch.

@Mistborn Mistborn closed this Sep 12, 2013
@whimboo
Copy link
Contributor

whimboo commented Sep 12, 2013

Why has this PR been closed? It's still necessary beside the mozmill changes.

@whimboo whimboo reopened this Sep 12, 2013
@Mistborn
Copy link
Author

Sorry, that was a misclick. I'll get the pull request fixed up.

…mation scrips to provide improved logging/debugging
@whimboo
Copy link
Contributor

whimboo commented Sep 13, 2013

That's a really wonderful patch! Applied it locally with the other changes for Mozmill 1.5 in place too, and it works like a charm! I wonder why you haven't found us earlier, given the usefulness of the patch! It will be in the next release.

Please let me know if you are interested in something else.

whimboo pushed a commit that referenced this pull request Sep 13, 2013
@whimboo
Copy link
Contributor

whimboo commented Sep 13, 2013

I have landed it as b8a9609

@whimboo whimboo closed this Sep 13, 2013
@Mistborn Mistborn deleted the hotfix-1.5 branch September 13, 2013 15:44
@Mistborn
Copy link
Author

Cheers. And it only took me 4 months to get the patch to you :p.

I'd love to help you out more in the future, but I probably won't have the spare time in the near future, seeing as I've landed a full-time programming job (partly thanks to being able to put "wrote code for the Mozilla foundation" on my resume ;-).)

@whimboo
Copy link
Contributor

whimboo commented Sep 13, 2013

That makes full sense. Great to hear that! However, whenever you feel that you want to learn something more please let me know and drop me an email. Thanks for your contribution Vlad!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants