This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Bug 798163 - Fixed failing test testWaitForPageLoad in mutt/tests/js/utils/pageload.js #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes bug https://bugzilla.mozilla.org/show_bug.cgi?id=798163 |
| @@ -118,7 +118,7 @@ var testWaitForPageLoad = function () { | |||
| controller.waitForPageLoad(frameController.window.document); | |||
|
|
|||
| // Once the iframe has been loaded assert that the element exists | |||
| var home = new elementslib.MozMillElement("ID", "home-fx", {document: frameWindow.document}); | |||
| var home = new elementslib.MozMillElement("ID", "test-div", {document: frameWindow.document}); | |||
There was a problem hiding this comment.
I would suggest changing the name of this variable to elem or similar.
|
@davehunt done! |
|
Looks good and passes for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.