Bug 762126 - Allow to specify the screenshot path via the persisted object (CLI option) #81
Conversation
| let file = Cc["@mozilla.org/file/directory_service;1"] | ||
| .getService(Ci.nsIProperties).get("TmpD", Ci.nsILocalFile); | ||
| file.append("mozmill_screenshots"); | ||
| var frame = {}; Components.utils.import('resource://mozmill/modules/frame.js', frame); |
There was a problem hiding this comment.
if we import frame I would say we should do it globally.
There was a problem hiding this comment.
Could you provide some guidance here? If I take this out of the method scope I am no longer able to retrieve the screenshotPath. No errors, but the screenshot is saved in the temporary directory.
There was a problem hiding this comment.
Where have you moved this line to? To the top of the module? Where the other import statements are? That should work and I don't see a reason why it fails. I would need some code to give a qualified answer.
…events. r=jhammel
…nges in bug 776931. r=ahal
…bject (CLI option)
Conflicts: mozmill/mozmill/__init__.py mozmill/mozmill/extension/resource/stdlib/utils.js
|
I rebased and got in a bit of a mess here, so I've moved to another pull request (#88). |
|
You can always force a push or retrieve the code again from your remote branch. Just for the next time. |
This created the file in the appropriate directory, however I was unable to open the image even if it was created in the temporary path location. There also seems to be some discrepancy with file types - a comment mentions PNG but the file name is JPG.