This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Bug 656505 - jsbridge will wait forever instead of timing out if a non-multiple of 0.25 is used. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-multiple of 0.25 is used.
| ttl = 0 | ||
| while ttl < timeout: | ||
| deadline = datetime.now() + timedelta(seconds=timeout) | ||
| found_socket = False |
There was a problem hiding this comment.
The name I have given for the variable was just an example. When looking at this function we do not search for the socket but trying to connect to the given port at the host. So 'connected' would be a much better name here.
Mind also adding a blank line before the while loop so we separate those blocks?
Otherwise looks good and I'm happy to get this checked in.
- separated while loop - "found_socket" -> "connected"
|
Commit 79f4df0 added with addressed comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for Bug 656505.