This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Add Optimizely experiment 3540700460 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Regexp used for targeting | ||
| function snippetRegexp() { | ||
| 'use strict'; | ||
| return /^.*www\.mozilla\.org\/.+\/firefox\/new\/.+utm_source=google.+utm_medium=paidsearch.+utm_campaign=sem2015Q3.*$/; |
There was a problem hiding this comment.
Since this test is en-US only, could simplify the regex a bit by specifying locale.
|
One small nit on the URL targeting regex, but otherwise looks good! r+wc |
openjck
force-pushed
the
optimizely-3540700460-sem-campaign
branch
from
f3a9c28
to
b99d22d
Compare
|
Updated 😄 |
| // Regexp used for targeting | ||
| function snippetRegexp() { | ||
| 'use strict'; | ||
| return /^.*www\.mozilla\.org\/en\-US/firefox\/new\/.+utm_source=google.+utm_medium=paidsearch.+utm_campaign=sem2015Q3.*$/; |
There was a problem hiding this comment.
One last nit - escape the backslash before firefox.
There was a problem hiding this comment.
Yep, great catch. Updated!
openjck
force-pushed
the
optimizely-3540700460-sem-campaign
branch
from
b99d22d
to
01b9fe8
Compare
|
All good! r+ |
jpetto
added a commit
that referenced
this pull request
Oct 8, 2015
Add Optimizely experiment 3540700460
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.