Skip to content

Commit

Permalink
Include previous day's builds in potential inbound range
Browse files Browse the repository at this point in the history
Starting from the current nightly revision may not be good enough, as there
may have been commits to inbound between the time yesterday's nightly was
built and the last time that m-c commit was merged into inbound.

(this solution is not perfect either but it should work for 99% of cases)

https://bugzilla.mozilla.org/show_bug.cgi?id=962742
  • Loading branch information
wlach committed Feb 4, 2014
1 parent 3031f22 commit 4b3ceb2
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions mozregression/regression.py
Expand Up @@ -147,10 +147,15 @@ def bisect_nightlies(self, goodDate, badDate, skips=0):

if midDate == badDate or midDate == goodDate:
print "Got as far as we can go bisecting nightlies..."
self._ensureMetadata(goodDate, badDate)
if self.appname == 'firefox' or self.appname == 'fennec':
self._ensureMetadata(goodDate, badDate)
self.printRange(goodDate, badDate)
print "... attempting to bisect inbound builds"
print "... attempting to bisect inbound builds (starting " \
"from previous day, to make sure no inbound revision is " \
"missed)"
prevDate = goodDate - datetime.timedelta(days=1)
self.nightlyRunner.install(prevDate)
self.lastGoodRevision = self.nightlyRunner.getAppInfo()[1]
self.bisect_inbound()
return
else:
Expand Down

0 comments on commit 4b3ceb2

Please sign in to comment.