Skip to content

Commit

Permalink
keep downloading background files on retry verdict
Browse files Browse the repository at this point in the history
  • Loading branch information
parkouss committed Jul 12, 2015
1 parent ad3b267 commit 5d2eff7
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions mozregression/bisector.py
Expand Up @@ -470,15 +470,24 @@ def _bisect(self, handler, build_data):
self.test_runner, self.fetch_config,
dl_in_background=self.dl_in_background)

previous_verdict, previous_build_infos = None, None
try:
while True:
mid = bisection.search_mid_point()
result = bisection.init_handler(mid)
if result != bisection.RUNNING:
return result

mid, build_infos = bisection.download_build(mid)
if previous_verdict == 'r':
# if the last verdict was retry, do not download
# the build. Futhermore trying to download if we are
# in background download mode would stop the next builds
# downloads.
build_infos = previous_build_infos
else:
mid, build_infos = bisection.download_build(mid)
verdict, app_info = bisection.evaluate(build_infos)
previous_verdict = verdict
previous_build_infos = build_infos
bisection.update_build_info(mid, app_info)
result = bisection.handle_verdict(mid, verdict)
if result != bisection.RUNNING:
Expand Down

0 comments on commit 5d2eff7

Please sign in to comment.