Skip to content

Commit

Permalink
Change inbound progress message to talk about "builds" instead of "re…
Browse files Browse the repository at this point in the history
…visions" (#457)

There may be less builds than actual revisions if some of the builds were bad,
see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1384136
  • Loading branch information
wlach committed Jul 27, 2017
1 parent aba549a commit e747885
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion mozregression/bisector.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class InboundHandler(BisectorHandler):

def _print_progress(self, new_data):
LOG.info("Narrowed inbound regression window from [%s, %s]"
" (%d revisions) to [%s, %s] (%d revisions)"
" (%d builds) to [%s, %s] (%d builds)"
" (~%d steps left)"
% (self.build_range[0].short_changeset,
self.build_range[-1].short_changeset,
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_bisector.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ def test_print_progress(self, logger):
]

self.handler._print_progress(new_data)
self.assertIn('from [12, 12345] (4 revisions)', log[0])
self.assertIn('to [1234, 12345] (2 revisions)', log[0])
self.assertIn('from [12, 12345] (4 builds)', log[0])
self.assertIn('to [1234, 12345] (2 builds)', log[0])
self.assertIn('1 steps left', log[0])

@patch('mozregression.bisector.LOG')
Expand Down

0 comments on commit e747885

Please sign in to comment.