Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for windows adhoc signing (bug 1839227) #1424

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Aug 9, 2023

  • update adhoc-sign script to support windows installer
  • rename unsigned installer binary
  • add workflow step to print manifest

- update adhoc-sign script to support windows installer
- rename unsigned installer binary
@zzzeid zzzeid marked this pull request as ready for review August 9, 2023 15:02
@zzzeid zzzeid requested review from cgsheeh and dklawren August 9, 2023 15:02
cgsheeh
cgsheeh previously approved these changes Aug 9, 2023
Copy link
Member

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bin/adhoc-sign.py Outdated Show resolved Hide resolved
bin/adhoc-sign.py Show resolved Hide resolved
bin/adhoc-sign.py Show resolved Hide resolved
@zzzeid zzzeid requested a review from cgsheeh August 10, 2023 12:30
@zzzeid zzzeid merged commit bb9c5ef into main Aug 10, 2023
17 checks passed
@zzzeid zzzeid deleted the zeid/bug-1839227-windows-installer-signing branch August 10, 2023 19:47
aliesbelik added a commit to ScoopInstaller/Extras that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants