Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splash_hook: run hook only on darwin (bug 1851916) #1444

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Sep 7, 2023

Prior to this change, the splash hook will run on all platforms. It should only run on macOS.

@zzzeid zzzeid marked this pull request as ready for review September 7, 2023 13:12
@zzzeid zzzeid marked this pull request as draft September 7, 2023 15:28
@zzzeid zzzeid force-pushed the zeid/bug-1851916-fix-splash-issue branch from a87f9a8 to 152df6f Compare September 7, 2023 16:56
@zzzeid zzzeid force-pushed the zeid/bug-1851916-fix-splash-issue branch from 152df6f to 8888c99 Compare September 7, 2023 17:33
@zzzeid zzzeid marked this pull request as ready for review September 7, 2023 18:08
@zzzeid zzzeid requested a review from cgsheeh September 7, 2023 18:08
@zzzeid zzzeid merged commit 6e3cfa2 into main Sep 7, 2023
21 checks passed
@zzzeid zzzeid deleted the zeid/bug-1851916-fix-splash-issue branch September 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants