Bug 1536013 - Select win64-aarch64 builds when appropriate. #518
Conversation
There was a problem hiding this comment.
This all looks reasonable to me, I just added you as a collaborator to the mozregression repository, so feel free to merge when ready. I'd like to upload a new revision of mozregression today if possible (there are some other changes which are overdue to go out).
|
@wlach ah, I was actually thinking that the proper way to do this would be to update mozinfo and push a new version of that first. It should probably be returning 64 bits for ARM64, as it does for x86-64 even when running on 32-bit Python. (It might also want to return aarch64 for processor instead of ARM64, ala x86_64 instead of AMD64) |
|
Thanks a lot for the collaborator add! |
|
@KwanEsq oh ok, if there's a more elegant fix involving mozinfo, let's go for that. I probably shouldn't review a patch for that, but can help with pushing that out to pypi once it's landed. |
|
for now i'll do a new release of mozregression with the other fixes that are pending |
|
Whoops, pushed the wrong branch, didn't mean to do that yet. |
Due to a too-broad regex trying to mozregress jsshell on win64 will have been grabbing the wrong build for the architecture ever since aarch64 builds started being produced. Adds a test for this.
Doing this to hopefully get a build for testing.