Change expected response code for api delete method to 200 from 204

[bobsilverberg]

This addresses, at least partially, issue #158.

My investigation indicates that the status code returned from a delete request against the API is now 200, whereas before it was 204. This fixes all of the errors that state AssertionError: Deletion of product Test Product xxx failed.

@peterbe or @camd can either of you confirm that this is expected, i.e., it is correct that we should be looking for a 200 response rather than a 204 response from a delete request now?

This does not address all of the HTTPError: 400 Client Error: BAD REQUEST that also showed up in the report [1]. I will need to investigate those separately.

[1] https://webqa-ci.mozilla.com/view/MozTrap/job/moztrap.stage.saucelabs/82/HTML_Report/

[bobsilverberg]

FTR, with this change all of the tests pass for me locally against staging. It might be worth implementing this first, and then waiting to see if those 400 errors come back.

[peterbe]

r+

New tastypie returns a 204 for deletes but moztrap dislikes that and instead changes it to 200. The comments in the code explains it better. I'm still a bit uncertain why it was 204 before when mtapi.py clearly avoids that. Either way, the django 1.4 to django 1.5 upgrade was an enormous amount of work and the necessary upgrade to modern tastypie was huge so I must have lost track of some details.

Either way, moztrap prefers 200s on those deletes.

[bobsilverberg]

Thanks @peterbe. I'm going to merge this in to restore coverage.