This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Api for product and productversion #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial work on product some logging that will need to go later
* update some doc strings * add test cases for invalid ProductResource.obj_create input
| from tastypie.authorization import Authorization | ||
| from tastypie.resources import ModelResource, ALL, ALL_WITH_RELATIONS | ||
| from tastypie import fields | ||
|
|
||
| from .models import Product, ProductVersion, ApiKey | ||
| from ..environments.api import EnvironmentResource | ||
| from ..mtapi import MTResource, MTAuthorization, MTApiKeyAuthentication |
There was a problem hiding this comment.
yeah, good call on this move.
There was a problem hiding this comment.
it's a good thing you like it, because otherwise there was gonna be an unresolvable include loop =)
changes pursuant to review comments
| if not isinstance(productversions, list): | ||
| raise KeyError(pv_required_msg) | ||
| if not len(productversions): | ||
| raise KeyError(pv_required_msg) |
There was a problem hiding this comment.
While looking into how to hide those 500 errors, it occurred to me that a 500 error is the wrong thing. If the data sent to the server is wrong, it should return a 400 (Bad Request). And so just throwing an exception here causing a 500 isn't the right way to go. I hunted around a bit, and here's the right way to initiate a 400 error:
except KeyError:
raise ImmediateHttpResponse(response=http.HttpBadRequest(pv_required_msg))
and at the top, import these:
from tastypie import http
from tastypie.exceptions import ImmediateHttpResponse
Then change your tests to expect 400s instead and you're good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is worth noting that ProductResource.obj_update() does not overwrite the productversion list, it just adds to it. This is not RESTful, but is in-line with the fact that we don't allow PUT to lists.