This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
fixes bug 1165411 - Optimize modelfilter choices #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
changed the title
peterbe
changed the title
| @classmethod | ||
| def delete_modelfilter_choices_cache(cls, model): | ||
| cache_key = 'modelfilter-choices-%s' % (model._meta,) | ||
| # print cache_key |
|
r+ |
|
Comments removed and rebased into 1 commit. Your move mister :) |
camd
pushed a commit
that referenced
this pull request
May 22, 2015
…h_user-mysql-queries fixes bug 1165411 - Optimize modelfilter choices
|
Merged and Pushed to stage! :)
|
|
When this gets pushed to prod, let's all stick our heads into newrelic and see what difference it makes. If any :) |
| @@ -559,6 +561,11 @@ def test_choices(self): | |||
|
|
|||
| class ModelFilterTest(FiltersTestCase): | |||
| """Tests for ModelFilter.""" | |||
|
|
|||
| def setUp(self): | |||
| super(ModelFilterTest, self) | |||
There was a problem hiding this comment.
This looks like a bug - is it supposed to call super(...).setUp()?
There was a problem hiding this comment.
Seems to work without but...
#98 :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@camd r?
This is going to make a HUGE difference.
Actually, when I tested the pjax URLs with curl, it only became about a second faster. From hovering around 2.5seconds each request to about 1.7seconds.
But that's (less than) 1 seconds LESS of MySQL CPU burden to worry itself with. Instead of doing 8 big fat select statements on each list, it's now 0. (except every 1 hour is flushes the cache).