Add "missing-pixi-permitted" feature #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
PixelInformationProperty(pixi) box defined in HEIF (ISO 23008-12:2017) § 6.5.6 is required to be present per MIAF (ISO/IEC 23000-22:2019) specification § 7.3.6.6:However due to a bug (now fixed) in libheif, AVIF images lacking this property were created and may remain in the wild. After receiving https://bugs.chromium.org/p/chromium/issues/detail?id=1198455, Chrome relaxed their check for this requirement and it is unclear whether it will be reinstated.
Discussion is underway to modify MIAF to allow the pixi property to be omitted, but it's unclear whether or when that will happen. To allow for maximum flexibility to adjust mp4parse's behavior, this PR adds a
"missing-pixi-permitted"feature so the behavior can be finely tuned from within gecko without requiring an update of mp4parse code.47bff4c makes the change assuming MPEGGroup/MIAF#9 will be accepted. 891df7c adds the feature and test changes that are only required during this period of uncertainty and can be removed later.
See also