"Always open this site in..." option stopped working in Nightly

[bbhtt]

• Multi-Account Containers Version: 7.4.0
• Operating System: Arch Linux
• Firefox Version: 93.0a1 (2021-09-01) buildid: 20210901091701
• Other installed Add-ons: (tested in a blank profile)

Actual behavior

Nothing happens

Expected behavior

Assign the site to that container (confirmation page...) and reload it in the container.

Steps to reproduce

1. Open a website
2. Click extension -> "Always open this site in.."

Notes

Error in extension and browser console:

Promise rejected after context unloaded: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved                                        
utils.js:117                                                                                                                                          
    alwaysOpenInContainer moz-extension://cb213c14-b1c7-4141-9b64-f01f90fb0f4c/js/utils.js:117 

(Possibly something happened between builds from 2021-08-26 to 2021-09-01)

[Fanolian]

Last good Nightly: 2021-08-31
First bad Nightly: 2021-09-01
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e8a630d41a7755dbc6c19093f96a89d8fd351b10&tochange=18d7ddf67682e3eb75376f56e4f014c81d2596b3
Changelist: https://mrotherguy.github.io/fx-nightly-changelog/?date=2021-09-01

Bisecting autoland builds:
pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ab5b37f83023f926201c2b226e35076910ce6fd4&tochange=2dc4f1baccc82806eb203617b0184fa634fea3e5

This is regressed by Bug 1708243 - Stop depending on framescripts with ExtensionGlobal, particularly part 2 of the patch.

[Fanolian]

I went ahead and filed Bug 1729395 - Firefox Multi-Account Containers's "Always Open This Site in" does not work after bug 1708243 part 2 since it is affecting a popular "built by Firefox" extension.

[Rob--W]

utils.js sends a message:

multi-account-containers/src/js/utils.js

Lines 113 to 117 in 4b56a2f

	async alwaysOpenInContainer(identity) {
	const currentTab = await this.currentTab();
	const assignedUserContextId = this.userContextId(identity.cookieStoreId);
	if (currentTab.cookieStoreId !== identity.cookieStoreId) {
	return await browser.runtime.sendMessage({

alwaysOpenInContainer has two callers, both of which close the page:

• multi-account-containers/src/js/pageAction.js

  Lines 24 to 25 in 4b56a2f

  	Utils.alwaysOpenInContainer(identity);
  	window.close();

• multi-account-containers/src/js/popup.js

  Lines 1225 to 1226 in 081ea0b

  	Utils.alwaysOpenInContainer(identity);
  	window.close();

[mdmcnamara]

Thanks, team!! Sincerely appreciate your attention on this one.

[niikoo]

+1
Also applies to Firefox Nightly for Android

[Rob--W]

+1
Also applies to Firefox Nightly for Android

Huh are you using container tabs on Firefox Nightly (Fenix)?
The implementation of containers is incorrect and unsupported; using it will result in the loss of data in the future when the bug is fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1643740

[niikoo]

+1
Also applies to Firefox Nightly for Android

Huh are you using container tabs on Firefox Nightly (Fenix)?
The implementation of containers is incorrect and unsupported; using it will result in the loss of data in the future when the bug is fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1643740

Thanks for the information.

[zombie]

The original issue here is that there is no await for the (async) Utils.alwaysOpenInContainer() method at these two call sites:
https://github.com/mozilla/multi-account-containers/blob/4b56a2f0bb/src/js/pageAction.js#L24-L25
https://github.com/mozilla/multi-account-containers/blob/081ea0bed/src/js/popup.js#L1225-L1226

This means that sendMessage() is called after the popup is already closed, which was never guaranteed to work. While I landed a fix in Firefox to make it work again, I still recommend fixing the extension to not depend on this behavior as it may stop working in the future.

[dannycolin]

Closing as bug 1729395 has been fixed upstream.