Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing persistent selection highlight for container colors and icons #2438

Closed
2 tasks done
acornestean opened this issue Nov 1, 2022 · 2 comments · Fixed by #2428
Closed
2 tasks done

Missing persistent selection highlight for container colors and icons #2438

acornestean opened this issue Nov 1, 2022 · 2 comments · Fixed by #2428
Labels
bug Something is broken!

Comments

@acornestean
Copy link

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

  1. Install the 8.1.0 version of Multi-Account Containers
  2. Open the Multi-Account Containers pop-up and click on “Manage Containers”
  3. Click on “+ New Container” to create a new container
  4. In the ensuing panel, input a name for the new container, select a color and then an icon
  5. Notice that when picking the container icon, the previously selected color is not highlighted to mark the user’s choice
2022-11-01_14h04_01.mp4

Actual behavior

Container color and icon options are not marked/highlighted as selected once chosen.

Expected behavior

Container color and icon options should be marked/highlighted as selected once chosen.

Additional informations

This is a regression, as in the currently available Multi-Account Containers version (8.0.7) on AMO, this issue does not occur.

2022-11-01_14h07_51.mp4

Provide a copy of Troubleshooting Information page (optional)

No response

@acornestean acornestean added the bug Something is broken! label Nov 1, 2022
@dannycolin dannycolin linked a pull request Nov 1, 2022 that will close this issue
@acornestean
Copy link
Author

Update:
In dark mode, the highlight for the radio buttons is present and visible.

@acornestean
Copy link
Author

Verified as Fixed with version 8.1.1 of Multi-Account Containers.

The highlight for the radio buttons is present and visible in both light and dark mode.

Tested on the latest Nightly and Beta under Windows 10, Ubuntu 16.04 LTS and macOS 11.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant