Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select a container for each new tab" setting fails to work on Ctrl-T keyboard-shortcut; only works via mouseclick #2535

Open
2 tasks done
jwmh opened this issue May 25, 2023 · 2 comments
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central

Comments

@jwmh
Copy link

jwmh commented May 25, 2023

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

"Select a container for each new tab" setting fails to work on Ctrl-T keyboard-shortcut; only works via mouseclick

Actual behavior

.

Expected behavior

It should work with Ctrl-T
(not only with mouseclicking the "+" new-tab button.)
Or,
an option should be provided
to give the SAME context-menu of "choose a container for this new tab" as happens when i click the "+" newtab button.

many thanks for all of this!
love this addon.

Additional informations

No response

Provide a copy of Troubleshooting Information page (optional)

No response

@KittyKatt
Copy link

If you don't mind my asking, what is blocking this from being looked at? Is it just developer time?

@dannycolin
Copy link
Collaborator

dannycolin commented Oct 5, 2023

If you don't mind my asking, what is blocking this from being looked at? Is it just developer time?

Developer time is definitely part of it. Other blockers are:

  • It needs to be implemented upstream (in Firefox itself) because we can't override builtin shortcuts from the addon. See https://bugzilla.mozilla.org/show_bug.cgi?id=1646985 for upstream bug.
  • There might be a bit of UX/a11y work to do on how the user will interact with the menu. Currently, the option only opens the menu but doesn't select an item and there's no accelkey (the small underline under a letter of each of the items) so you can only use arrow keys to navigate the menu. This could probably be done in a separated bug tho.

If you can and want to contribute a patch, you can follow the guide to get a development environment ready https://firefox-source-docs.mozilla.org/setup/index.html. You can also join Mozilla Matrix server at https://chat.mozilla.org and ask questions in #introduction:mozilla.org. We have a quick how-to guide if you never used Matrix at https://wiki.mozilla.org/Matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central
Projects
None yet
Development

No branches or pull requests

3 participants