Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable onboarding from Firefox policies #2565

Open
2 tasks done
rungitringit opened this issue Aug 20, 2023 · 14 comments
Open
2 tasks done

Disable onboarding from Firefox policies #2565

rungitringit opened this issue Aug 20, 2023 · 14 comments
Assignees
Labels
Component: Panel Issues related to the browserAction panel Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon

Comments

@rungitringit
Copy link

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

Hello,

I'm creating a policy for a Linux SOE which will be deployed as a part of an OS image. I love that I can specify some default Containers using https://github.com/mozilla/policy-templates for the Firefox Multi-Account-Containers extension to get my users going in the right direction.

I want users to use Multi-Account-Containers without even noticing.

Actual behavior

Unfortunately users are forced to click through the introductory text in the extension - including ads for the Mozilla VPN they can't use in our corporate environment.

These pages are a barrier to usage of the extension. I really want users to use it by default, but I don't want to have to make them click through a few pages to make the extension usable.

Please add logic to skip the introductory text if the extension is installed via Firefox policies.
Thank you!

Expected behavior

Some way to automatically skip all the introductory pages for new users when Multi-Account-containers are install as a part of policies.json

Additional informations

In fact it would be awesome if you could work with the people building the Firefox policy templates to add the option to pre-configure which sites go in which containers, but that's another idea!

Provide a copy of Troubleshooting Information page (optional)

No response

@mkaply
Copy link

mkaply commented Sep 1, 2023

@dannycolin What do you think is the best way to do this?

@dannycolin dannycolin added 👍 Feature Request Feature requests users would like to see in this addon and removed bug Something is broken! labels Sep 5, 2023
@dannycolin
Copy link
Collaborator

@dannycolin What do you think is the best way to do this?

@mkaply In the popup logic, here, we're retriving the onboarding stage key from localStorage. We then load the appropriate panel according to the value of this key.

What we could do is check if there's a similar key in browser.storage.managed and if there's one we use it instead.

The administrator simply needs to add the key to their policies.json has (funnily you wrote it) explained in https://extensionworkshop.com/documentation/enterprise/adding-policy-support-to-your-extension/ :)

@mkaply
Copy link

mkaply commented Sep 5, 2023

That sounds perfect. Do you want to take it on or me? FYI, I'll be out the next three weeks, but I can tee it up for October.

@dannycolin
Copy link
Collaborator

That sounds perfect. Do you want to take it on or me? FYI, I'll be out the next three weeks, but I can tee it up for October.

I can take it. I'll try to have a patch ready for when you'll be back in october.

@dannycolin dannycolin self-assigned this Sep 5, 2023
@DamienCassou
Copy link

In fact it would be awesome if you could work with the people building the Firefox policy templates to add the option to pre-configure which sites go in which containers, but that's another idea!

I would also love that! Should I open a new issue?

@mkaply
Copy link

mkaply commented Nov 20, 2023

I would also love that! Should I open a new issue?

We already implemented that:)

https://mozilla.github.io/policy-templates/#containers

@DamienCassou
Copy link

We already implemented that:)

The policy-templates documentation only mentions specifying containers (with name, color and icon). What @rungitringit and me are looking for goes beyond that: We want a way to specify which domains go into which container.

@dannycolin
Copy link
Collaborator

@DamienCassou @mkaply It's definitely a different thing. You can open a new ticket for it if you wish.

@mkaply
Copy link

mkaply commented Nov 20, 2023

Doh, completely missed that part. Definitely worth opening a ticket. Hopefully it's straightforward.

@DamienCassou
Copy link

@dannycolin @mkaply @rungitringit: new issue #2601

@dannycolin dannycolin added Needs: Mozilla Central Needs changes in Mozilla-Central Component: Panel Issues related to the browserAction panel labels Nov 21, 2023
@dannycolin dannycolin changed the title Skip extension introductory pages when installed from a corporate policies.json Disable onboarding from Firefox policies Nov 21, 2023
@VeldoraTheDragon
Copy link

Hi there @dannycolin

I don't like to necrobump, but since the issue isn't marked as solved yet, I'll take my right to ask:

Some of our employees stumbled over the extension and would like to have it in our corporate environment, but as far I've tested, I also had my issues with the introduction and the asking to use sync or mozilla vpn.

I'd like to ask you, what's the status of implementing some configlets for the managed policy, to disable these things?
Thank you

@dannycolin
Copy link
Collaborator

I can work on this issue but I'd need a mozilla developer to review, cut a release and publish it on addons.mozilla.org.

My primary contact at Mozilla doesn't work there anymore so I'd have to find someone else with some free time to help. Until then, this issue is stalled sadly.

@mkaply
Copy link

mkaply commented Mar 21, 2024

Is the introductory stuff in the addon or in Firefox?

@dannycolin
Copy link
Collaborator

Is the introductory stuff in the addon or in Firefox?

Yes. It's the onboarding in the addon popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Panel Issues related to the browserAction panel Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

5 participants