Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not disable PTO when packets outstanding == 0 for initial/handshake #864

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Do not disable PTO when packets outstanding == 0 for initial/handshake #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions neqo-transport/src/recovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,13 @@ impl LossRecoverySpace {
debug_assert!(self.in_flight_outstanding > 0);
self.in_flight_outstanding -= 1;
if self.in_flight_outstanding == 0 {
qtrace!("remove_packet outstanding == 0");
self.pto_base_time = None;
qtrace!("remove_packet outstanding == 0 for space {}", self.space);

// See above comments; keep PTO armed for Initial/Handshake even
// if no outstanding packets.
if self.space == PNSpace::ApplicationData {
self.pto_base_time = None;
}
}
}
}
Expand Down