Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most of the Entry's fields should be optional #22

Closed
mmmavis opened this issue Jan 16, 2017 · 3 comments
Closed

Most of the Entry's fields should be optional #22

mmmavis opened this issue Jan 16, 2017 · 3 comments
Assignees
@alanmoo
Labels
MVP for Pulse Launch
Milestone
Launch

Comments

@mmmavis
Copy link
Member

mmmavis commented Jan 16, 2017 •
edited
Loading

Required

  • title
  • content_url
  • published_by (correct me if I'm worng - we can pull this directly from the logged in user profile and there's no need to have it on the submission form.)

Optional

  • description
  • thumbnail_url
  • tags
  • get_involved
  • get_involved_url
  • interest
  • internal_notes
  • featured
  • issues
  • creators

/cc @kristinashu @xmatthewx
@mmmavis
Copy link
Member Author

mmmavis commented Jan 16, 2017 •
edited
Loading

Sorry just checked models.py and seems like there are more fields we should make optional. I'll update the ticket description soon.

@mmmavis mmmavis changed the title thumbnail_url should be an optional field Most of the Entry's fields should be optional Jan 16, 2017
@mmmavis
Copy link
Member Author

mmmavis commented Jan 16, 2017

Ticket title and description have been updated!

@kristinashu
Copy link

Looks right to me!

@alanmoo alanmoo self-assigned this Jan 17, 2017
@alanmoo alanmoo added this to the Launch milestone Jan 17, 2017
alanmoo added a commit that referenced this issue Jan 17, 2017
@alanmoo
Simplify required fields
2c67aef 
Closes #22
@alanmoo alanmoo mentioned this issue Jan 17, 2017
Merged
alanmoo added a commit that referenced this issue Jan 20, 2017
@alanmoo
Simplify required fields (#31)
5f89af5 
* Simplify required fields

Closes #22

* Oops

* Update test for required content_url

* Split required fields test into two
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanmoo alanmoo

Labels
MVP for Pulse Launch
Projects
None yet
Milestone
Launch
Development

No branches or pull requests
3 participants
@kristinashu @alanmoo @mmmavis