Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

fixed "leverage rev_host grouping" issue #43

Merged
merged 1 commit into from Jun 13, 2012

Conversation

mzhilyaev
Copy link
Contributor

fixed by using "group by rev_host" query instead of pulling each individual url from places

@Mardak
Copy link
Member

Mardak commented Jun 12, 2012

Could you run some timing measurement to see if this changes performance much for the better or worse?

@mzhilyaev
Copy link
Contributor Author

timing for addon loading

  1. Profile is being read first time
    info: query time 2614
    info: number crunching time 4
  2. Profile is being read again - Firefox is loaded second time in a raw
    info: query time 140
    info: number crunching time 5

It appears that simply reading places.sql is what takes the most time. When the file is buffered, query time is reduced by 20x

@Mardak
Copy link
Member

Mardak commented Jun 13, 2012

What are the numbers before with individual urls and after with rev_host?

@mzhilyaev
Copy link
Contributor Author

Disregard the data above. The new data here
Before the rev_host change, the addon timing was this:

info: query completion 1757
info: number crunching 5

After rev_host implementation timing is this:
info: query time 138
info: number crunching time 5

I no longer can reproduce time difference between fresh and cached porfile

@Mardak
Copy link
Member

Mardak commented Jun 13, 2012

The timing looks good. This pull request has unnecessary changes though. Just take the d1763df commit and rebase it to master and don't include the timing commit.

…rouping in SQL

fixed the sql query to use group_by on rev_host instead of collecting each
places url individually
Mardak added a commit that referenced this pull request Jun 13, 2012
fixed "leverage rev_host grouping" issue
@Mardak Mardak merged commit 0814d5e into mozilla:master Jun 13, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants