Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rr fails to build when using this overlay with newer nixpkgs #300

Closed
ckoparkar opened this issue Dec 30, 2022 · 5 comments · Fixed by #301
Closed

rr fails to build when using this overlay with newer nixpkgs #300

ckoparkar opened this issue Dec 30, 2022 · 5 comments · Fixed by #301

Comments

@ckoparkar
Copy link
Contributor

As of NixOS/nixpkgs@ad97a48, rr in nixpkgs has switched back to accepting a stdenv argument instead of gcc9Stdenv. As a result, rr fails to build when using this overlay with newer nixpkgs:

error: anonymous function at /nix/store/.../pkgs/development/tools/analysis/rr/default.nix:1:1 called with unexpected argument 'gcc9Stdenv'

       at /nix/store/.../lib/customisation.nix:72:16:

           71|     let
           72|       result = f origArgs;
             |                ^
           73|
(use '--show-trace' to show detailed location information)

I believe this could be fixed by reverting 66b51ed.
ckoparkar added a commit to ckoparkar/nixpkgs-mozilla that referenced this issue Dec 30, 2022
@ckoparkar
Revert "Fix rr-overlay.nix for modern nixpkgs"
e365e13 
This reverts commit 66b51ed.

Fixes mozilla#300.
@ckoparkar ckoparkar mentioned this issue Dec 30, 2022
Merged
@Artturin
Copy link
Contributor

that override should be removed https://github.com/NixOS/nixpkgs/blob/dea47fa228a4befa22bdda738f6348dd8a41e22c/pkgs/development/tools/analysis/rr/default.nix#L73

@ckoparkar
Copy link
Contributor Author

@Artturin It looks like I created this PR too soon. I'm afraid I don't know enough Nix to follow your suggestion. Are you saying that this is something that can be / should be fixed without making changes to this overlay?

@Artturin
Copy link
Contributor

rr-overlay.nix is unnecessary because rr already has i686-linux in its supported platforms

ckoparkar added a commit to ckoparkar/nixpkgs-mozilla that referenced this issue Dec 31, 2022
@ckoparkar
Remove rr overlay
beb8d51 
As of
NixOS/nixpkgs@541d30a
the upstream rr package supports i686-linux out of the box,
making this overlay unnecessary.

h/t @Artturin:
mozilla#300 (comment).
@ckoparkar
Copy link
Contributor Author

Got it, thanks!

It looks like the upstream rr package has supported i686 for quite some time (NixOS/nixpkgs@541d30a).

What do you think @nbp?

@nbp
Copy link
Collaborator

nbp commented Jan 26, 2023

I am ok with removing it.

ckoparkar added a commit to ckoparkar/nixpkgs-mozilla that referenced this issue Jan 26, 2023
@ckoparkar
Remove rr overlay
9b05600 
As of
NixOS/nixpkgs@541d30a
the upstream rr package supports i686-linux out of the box,
making this overlay unnecessary.

h/t @Artturin:
mozilla#300 (comment).
@nbp nbp closed this as completed in #301 Feb 2, 2023
nbp pushed a commit that referenced this issue Feb 2, 2023
@ckoparkar @nbp
Remove rr overlay
85eb0ba 
As of
NixOS/nixpkgs@541d30a
the upstream rr package supports i686-linux out of the box,
making this overlay unnecessary.

h/t @Artturin:
#300 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rr overlay ckoparkar/nixpkgs-mozilla
3 participants
@nbp @ckoparkar @Artturin