Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

MetaBlack font link fixed #17

Merged
merged 4 commits into from Jun 14, 2013
Merged

MetaBlack font link fixed #17

merged 4 commits into from Jun 14, 2013

Conversation

adelq
Copy link
Contributor

@adelq adelq commented Apr 15, 2013

Old link in HTML style was broken

Old link was broken
@fwenzel
Copy link
Member

fwenzel commented Apr 15, 2013

Thanks for working on this bug; but I actually think we have an SSL CDN we should use instead of deep-linking to the mozorg webserver.

@tofumatt
Copy link
Contributor

If anything, the proper thing to do would be to use // so as to use whatever protocol the site is using.

I'm not sure nightly is setup to use the CDN. I have no idea how that works, actually.

…lla.org

Having font on different domain causes longer load times and is not an adequate solution
@adelq
Copy link
Contributor Author

adelq commented Apr 15, 2013

Fixed to take the approach that addons.mozilla.org took with mozilla/zamboni@6f312fd by having the font on their own repo. Not on the CDN as far as I know, but is definitely better than using the mozilla.org copy

@mnoorenberghe
Copy link

FYI Bug 866997 was just filed for the mixed content issue.

@tofumatt
Copy link
Contributor

tofumatt commented Jun 6, 2013

I don't actually see the new MetaBlack font files in the repo, and we'll need both EOT and WOFF versions for this to be merged in.

That said, if you can update this PR I'll merge this in quick. Sorry for the delays on this one.

@adelq
Copy link
Contributor Author

adelq commented Jun 12, 2013

Updated pull request, everything is good to go.

tofumatt pushed a commit that referenced this pull request Jun 14, 2013
MetaBlack font link fixed
@tofumatt tofumatt merged commit 0e56030 into mozilla:master Jun 14, 2013
@retornam
Copy link
Member

retornam commented Aug 6, 2013

@tofumatt Has this made it to production yet. Bug https://bugzilla.mozilla.org/show_bug.cgi?id=866997 has been reopened because people are still experiencing the mixed content issue

@tofumatt
Copy link
Contributor

tofumatt commented Aug 6, 2013

I thought so, but it seems like it never did. I filed a bug to get it deployed.

On 2013-08-06, at 4:50 PM, retornam notifications@github.com wrote:

@tofumatt Has this made it to production yet. Bug https://bugzilla.mozilla.org/show_bug.cgi?id=866997 has been reopened because people are still experiencing the mixed content issue


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants