Fix Bug 1213020 - Update nightly.mozilla.org to include B2GDroid builds #46
Conversation
|
|
||
| <!-- B2GDroid promo --> | ||
| <!-- Spotlight Activity Tag: Mozilla (6247) | Mozilla B2G Activity Tag 2 (52162) | Mozilla Spots (4669) | Expected URL: --> | ||
| <script> |
There was a problem hiding this comment.
We already have a JS file for code; JS should go in https://github.com/mozilla/nocturnal/blob/master/js/nightly.js
|
r- Sorry, but I think this is the wrong approach to this problem. To add an item to the nightly site it needs to be added to Let me know if you need any guidance. |
|
The campaign code was provided in Bug 1213905 and permanent link was provided in Bug 1213020. Since the file is not on FTP, and because of the campaign code, I just hardcoded the link. |
|
The tracking code seems very weird to me; we already have Google Analytics and wonder why we don't use that. Adding the HTML directly is harder to maintain and also puts your new build at the very top of the page, which I don't think is best (desktop browsers should be at the top of the nightly page). The nightly site isn't set up to handle static URLs right now, so that functionality needs to be added into the Python script. Would you be interested in doing this? |
|
I'm working on it. |
|
Okay, now it looks much better. The hardcorded HTML is gone, JS is in the separate file. I don't know why we don't use GA events here neither, though. |
|
That was fast! 👍
I'm just working on something else and it's a bit late here in England, but I'll check this out either tonight or first thing tomorrow morning, thanks!
|
|
Thanks @tofumatt! |
| ftGoalTagPix52162.src = "http://servedby.flashtalking.com/spot/8/6247;52162;4669/?spotName=Mozilla_B2G_Activity_Tag_2&cachebuster="+num; | ||
|
|
||
| event.preventDefault(); | ||
| return false; |
There was a problem hiding this comment.
You shouldn't need return false; as you're already using event.preventDefault();
|
See proposed code tweaks, but after that this is good, thanks! Ping me when they're made and I'll merge it in and we can file the push request with IT. |
|
Kohei, can you swap out the tag with 52280? |
|
Fixed the suggested points except the arrangement, and swapped the campaign tag. |
|
Awesome, thanks. Sorry I’ve been so back-and-forth with this one. Gonna see what the campaign folks think on the placement, after that it’s good.
|
|
FWIW I agree with @tofumatt that Desktop should be the prominent product on the site. |
|
jbertsch is fine with this going below desktop. @kyoshino I don't think this was called out explicitly, but we should make sure the implementation of this tracking pixel respects users with DNT. |
|
Okay, will update the code shortly. |
|
Added a DNT check and rearranged the order to put B2GDroid between Mobile (renamed the label to Android for clarity) and Desktop B2G like this:
|
Fix Bug 1213020 - Update nightly.mozilla.org to include B2GDroid builds
|
Thanks so much for all the work on this patch; sorry it took so long. Filed the deploy bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1224035 |
|
Thanks @tofumatt for your timely review! |
No description provided.