This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
bug951368 - Force to specify path to translation_directory #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +71,7 @@ describe("Middleware setup", function (){ | |||
| }).throw(); | |||
| }); | |||
|
|
|||
| it.skip("should throw an error when no path to translation_directory specified", function(){ | |||
| it("should throw an error when no path to translation_directory specified", function(){ | |||
There was a problem hiding this comment.
Is there a reason you aren't enabling the test from line 90?
There was a problem hiding this comment.
Yes. Both patch needs to land first before the next one can be turn on.
On Thursday, December 19, 2013, Kieran Sedgwick wrote:
In test/test.js:
@@ -71,7 +71,7 @@ describe("Middleware setup", function (){
}).throw();
});
it.skip("should throw an error when no path to translation_directory specified", function(){it("should throw an error when no path to translation_directory specified", function(){Is there a reason you aren't enabling the test from line 90?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/32/files#r8482237
.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=951368