-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about:studies #750
Comments
Any chance this could be about:studies instead of experiments? We try not to use experiments whenever possible because it has negative connotations. |
Works for me. @telliot does that work for Pioneer as well? |
@andymikulski's kicking butt on the admin side, so I'll be taking this on in his stead |
@gijsk I have a wip commit implementing Also, although out of scope for this particular issue, how would I get data from the parent process to the child process to get a list of studies / request that a study be disabled? Would I just use the child process message manager in the JS in the HTML page to send and receive events, and the parent process manager in the main add-on code? |
Whoops, forgot to link to the commit: Osmose@20e2b23 |
Update: I have a simple listing that gets a list of studies from the child process message manager, but I'm stuck on how the parent process will know to send the list of studies (outside of whenever the list is updated). Should it listen for an event from the child process? Should I be using |
The simplest way I know of checking what's happening manually is to open the page as the selected tab and, with the browser console, check This will stop you from running chrome-privileged script directly in the page. If you need to communicate with the page from a listener, you would do that from the content process script (shield-content-process.js). See e.g. this code for an example: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/content.js#324 The TL;DR is that your content page can dispatch a When you receive a message back from the parent, you check that the content page is still about:studies (see the code linked above) and then you can either pass the data via another custom event, or manipulate the page DOM directly from your process script. If you go the custom event route (which might be easier if you use react here) then I expect you'll want to use Does that make sense? :-) |
Users should be able to visit
about:experiments
to see a listing of the experiments that they have participated in. An outdated visual mockup based off the about:addons listing is available here.To simplify things, this issue only covers adding a blank page at that URL. Subsequent issues will cover the content.
The text was updated successfully, but these errors were encountered: