Log navigator.oscpu via the client classification endpoint. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary measure intended to get data on what values for navigator.oscpu the userbase has. This will help guide a future implementation of OS targeting in filter expression. Fixes bug 1296028
|
I like these changes. r+ on this PR, once rweiss approves the data logging. |
| @@ -255,6 +255,7 @@ def LOGGING(self): | |||
| ACTION_IMPLEMENTATION_CACHE_TIME = values.IntegerValue(60 * 60 * 24 * 365) | |||
| NUM_PROXIES = values.IntegerValue(0) | |||
| API_CACHE_TIME = values.IntegerValue(30) | |||
| LOG_OSCPU_RATE = values.FloatValue(0.001) | |||
There was a problem hiding this comment.
New settings need to go in the docs.
|
I added the new setting to the docs. This is ready to merge once CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to implementing operating system filtering, I'd like to collect some data from users about what the value of
navigator.oscpuis, since we'll be using that value to filter by OS.This is marked as Do Not Merge because I'd like a data review from @rjweiss first, which happens via Bugzilla flags AFAICT. I (or anyone, really) can remove that tag once the data review on Bugzilla is approved.
Fixes bug 1296028.
@mythmon r? Since you're probably most familiar with how logging should be done.