Pin underscore.string and add to lints. #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the CI issue we are seeing on master.
The main issue is that any packages imported in JS need to be installed somewhere above the file for the lints to accept the import line. On dev systems, this works because we have everything installed for the recipe-server, but the lint runner doesn't install the recipe-server's packages.
Adding
underscore.stringto the lint packages is a bandaid to fix this, but we should probably think of a better solution in the future. Maybe a better eslint rule so we don't have to install things. Maybe just install everything in each project as we lint.Fixes #508