Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #633 from andymikulski/433-addon-storage-durability" #677

Merged
merged 3 commits into from Apr 13, 2017

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Apr 11, 2017

Looks like we didn't get enough review on #633, which is my fault (sorry about that). This reverts the merge of that PR, so we can go over it again better.

This reverts commit deff7bd, reversing
changes made to 606a355.

…orage-durability"

This reverts commit deff7bd, reversing
changes made to 606a355.
Copy link
Contributor

@gijsk gijsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just rs this. The make-xpi.sh change can probably just stay, though if it's simpler we can revert the entire thing.

@gijsk gijsk removed their assignment Apr 11, 2017
@mythmon
Copy link
Contributor Author

mythmon commented Apr 11, 2017

For context, since it wasn't clear to me, and I had to ask: "rs" means "rubber stamp", and it is a light review. To quote @gijsk: "I'm expecting that you know how to produce a backout for a given revision (or at least, github does)"

Copy link
Contributor

@Osmose Osmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the revert I generated for #676, which passed all my local tests, so this is good to me, although I'm with @gijsk on keeping the maxe-xpi.sh fix.

Automation failure seems unrelated.

@Osmose Osmose merged commit 08a649e into mozilla:master Apr 13, 2017
@mythmon mythmon deleted the revert-storage-check branch April 13, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants