Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #812: Pin Babili dependencies to known-good versions. #813

Merged
merged 2 commits into from Jun 14, 2017

Conversation

Osmose
Copy link
Contributor

@Osmose Osmose commented Jun 14, 2017

They weren't joking when they said Babili was beta-level software. But it's what we have to live with if we want minification and native async/await.

This actually only fixed some local issues I was hitting that were different than what CircleCI was hitting, but maybe this will fix that as well.

@Osmose
Copy link
Contributor Author

Osmose commented Jun 14, 2017

TC failure is #809 and shouldn't block this PR.

Copy link
Contributor

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change, regardless of it fixes the issue.

@mythmon
Copy link
Contributor

mythmon commented Jun 14, 2017

CI tests passed, but lints failed with the error:

/app/code/recipe-client-addon/test/unit/head_xpc.js
  41:7  error  'sinon' is assigned a value but never used  no-unused-vars

@Osmose Osmose merged commit 3cab778 into mozilla:master Jun 14, 2017
@Osmose Osmose deleted the babili-pinning branch June 14, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants