Gitlab #84
Gitlab #84
Conversation
jgmize
commented
May 8, 2019
•
jgmize
commented
- working .gitlab-ci.yml
- Add Gitlab section to readme
- delete jenkins pipeline in followup PR
- removed in remove Jenkinsfile #101
| script: | ||
| - docker/bin/build_images.sh | ||
| - docker/bin/push2dockerhub.sh | ||
| - bin/update-config.sh |
There was a problem hiding this comment.
Is there a reason we can't have these two combined (adding an entry in only)? Or are they just separated for now to call out that one is testing and will be deleted later?
There was a problem hiding this comment.
as discussed on zoom, let's keep both jobs for now, and we can use the gitlab branch in the furture for testing new versions of .gitlab-ci.yml outside of the master branch.
| @@ -5,10 +5,6 @@ set -ex | |||
| BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |||
| source $BIN_DIR/set_git_env_vars.sh | |||
|
|
|||
| DOCKER_USERNAME="${DOCKER_USERNAME:-mozjenkins}" | |||
|
|
|||
| docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD | |||
There was a problem hiding this comment.
Assuming these are now set in the cluster?
There was a problem hiding this comment.
the credentials are stored on the runner instances and interactive login using a password from an env var is neither needed nor desired.
| image_tag="mozorg/bedrock_${2}:${GIT_COMMIT}" | ||
| cmd="$3" | ||
| docker run --rm --user $(id -u) -v "$PWD:/app" --env-file "docker/envfiles/${env_file}.env" "$image_tag" bash -c "$cmd" | ||
| } |
There was a problem hiding this comment.
For my own edification, why do we no longer need this?
