Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab #84

Merged
merged 7 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@jgmize
Copy link
Member

commented May 8, 2019

  • working .gitlab-ci.yml
  • Add Gitlab section to readme
  • delete jenkins pipeline in followup PR

@jgmize jgmize marked this pull request as ready for review May 8, 2019

@jgmize jgmize requested a review from jpetto May 8, 2019

@jpetto

jpetto approved these changes May 9, 2019

Copy link
Member

left a comment

No blockers, just a few questions for my own understanding. 😀

script:
- docker/bin/build_images.sh
- docker/bin/push2dockerhub.sh
- bin/update-config.sh

This comment has been minimized.

Copy link
@jpetto

jpetto May 9, 2019

Member

Is there a reason we can't have these two combined (adding an entry in only)? Or are they just separated for now to call out that one is testing and will be deleted later?

This comment has been minimized.

Copy link
@jgmize

jgmize May 10, 2019

Author Member

as discussed on zoom, let's keep both jobs for now, and we can use the gitlab branch in the furture for testing new versions of .gitlab-ci.yml outside of the master branch.

@@ -5,10 +5,6 @@ set -ex
BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source $BIN_DIR/set_git_env_vars.sh

DOCKER_USERNAME="${DOCKER_USERNAME:-mozjenkins}"

docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD

This comment has been minimized.

Copy link
@jpetto

jpetto May 9, 2019

Member

Assuming these are now set in the cluster?

This comment has been minimized.

Copy link
@jgmize

jgmize May 10, 2019

Author Member

the credentials are stored on the runner instances and interactive login using a password from an env var is neither needed nor desired.

image_tag="mozorg/bedrock_${2}:${GIT_COMMIT}"
cmd="$3"
docker run --rm --user $(id -u) -v "$PWD:/app" --env-file "docker/envfiles/${env_file}.env" "$image_tag" bash -c "$cmd"
}

This comment has been minimized.

Copy link
@jpetto

jpetto May 9, 2019

Member

For my own edification, why do we no longer need this?

@jpetto jpetto merged commit 3e42d88 into master May 10, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.